handle graceful shutdown of consumers#137
Merged
kristinmerbach merged 14 commits intotrunkfrom Feb 25, 2026
Merged
Conversation
raghuramg
approved these changes
Feb 24, 2026
Contributor
raghuramg
left a comment
raghuramg
left a comment
There was a problem hiding this comment.
implemented logic to add wait for message to drain before shutting down.
code changes looks good to me
vkghub
added a commit
to dchbx/event_source
that referenced
this pull request
Feb 27, 2026
* handle graceful shutdown of Bunny (AMQP client) * rearrange methods * add more changes and specs * remove unused * add more specs * add railtie spec * fix typo * spec fix * fix path * revert spec config * revert spec * test spec * test one more change * remove unused code
kristinmerbach
pushed a commit
to dchbx/event_source
that referenced
this pull request
Mar 13, 2026
* Don't start event source until Rails is ready. (ideacrew#117) * Don't start event source until rails is ready. * Fix up when HTTP subscriber bindings are resolved. * Properly name parameter. * Fix http subscriber routing. * Add more documentation. * add support for amqp payload compress/decompress (ideacrew#119) * add support for amqp payload compress/decompress * publish compressed messages based on api configuration * publish binary data directly to rabbitmq * check if message bindings available * verify encoding before passing payload to consumer handler * refactor payload_codec, add specs * add mime encode/decode operations * add specs for mime encode/decode operations * update bunny queue proxy and remove payload_codec * remove zlib gem reference * log file size before and after encoding * update method names * update errors for encode/decode exceptions * add documentation for encode/decode operations * add default mime type encode as json for amqp protocol (ideacrew#120) * add default mime type encode json * update documentation * spec fixes * refactor json string check and specs * make sure decode errors don't block the queue (ideacrew#121) * add default mime type encode json * update documentation * spec fixes * refactor json string check and specs * don't block messages from processing when encountered decode error - added subscriber.ack to acknowledge the message * add spec fixes * added more logger messages --------- Signed-off-by: Raghu Ram <raghuramg83@gmail.com> * add exception handling for zlib compressed data errors (ideacrew#122) * handle graceful shutdown of consumers (ideacrew#137) * handle graceful shutdown of Bunny (AMQP client) * rearrange methods * add more changes and specs * remove unused * add more specs * add railtie spec * fix typo * spec fix * fix path * revert spec config * revert spec * test spec * test one more change * remove unused code * spec fix * fix one more spec --------- Signed-off-by: Raghu Ram <raghuramg83@gmail.com> Co-authored-by: Trey <lewis.r.evans@gmail.com> Co-authored-by: Raghu Ram <raghuramg83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://app.clickup.com/t/868gkd3ua